Importing the localized fitting file(xml) exported from EVE#2653
Open
jeffy-g wants to merge 13 commits intopyfa-org:masterfrom
Open
Importing the localized fitting file(xml) exported from EVE#2653jeffy-g wants to merge 13 commits intopyfa-org:masterfrom
jeffy-g wants to merge 13 commits intopyfa-org:masterfrom
Conversation
Fitting description limit extended to 500 characters localized fitting file sample
if use `applicationbound()` instead of `threadbound()`.
jeffy-g
force-pushed
the
fix-localized_import/note_limit
branch
from
e5b3e5b to
f9f0806
Compare
[skip ci]
jeffy-g
force-pushed
the
fix-localized_import/note_limit
branch
from
29e0a54 to
ff1bd81
Compare
Contributor
Author
|
The German and Russian localized fitting files export xml files with the exact same contents regardless of important names.
The layout of the |
Member
|
I will take a look at it (and possibly merge) later. Will make today release w/o this, sorry |
Contributor
Author
|
Okay! np :-) Please check it out, if there's anything you don't like or any problems, please fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I haven't played EVE for a while, but I've started playing again recently.
Inevitably, I ended up using
Pyfaagain,but I feel that I need to make some changes to the import of localized fitting files, so I am submitting a PR.
For simple testing, I created localized fitting files for each language and placed them in
tests/localized-fitting-files.You can see how it works by importing all the xml files at once with
Pyfa.It also seems that the character limit for fitting notes has been increased from 400 to 500,
so I've included those changes in this PR.
If the character count exceeds 500, the text will turn red.
thanks for reading o7